Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent validators being called repeatedly after inheritance #327

Merged
merged 3 commits into from Dec 25, 2018

Conversation

Projects
None yet
1 participant
@samuelcolvin
Copy link
Owner

samuelcolvin commented Dec 25, 2018

Problem was introduced in #320 I believe.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes
  • No performance deterioration (if applicable)
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever

@samuelcolvin samuelcolvin force-pushed the validator-inheritance branch from 5636bb9 to 4d283a4 Dec 25, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #327 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #327   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines        1771   1773    +2     
  Branches      344    345    +1     
=====================================
+ Hits         1771   1773    +2

@samuelcolvin samuelcolvin merged commit c725a4a into master Dec 25, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
deploy/netlify Deploy preview ready!
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@samuelcolvin samuelcolvin deleted the validator-inheritance branch Dec 25, 2018

@samuelcolvin samuelcolvin referenced this pull request Dec 28, 2018

Closed

Restore environment variable override behaviour #341

4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.