Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclass validation #334

merged 4 commits into from Dec 27, 2018

dataclass validation #334

merged 4 commits into from Dec 27, 2018


Copy link

@samuelcolvin samuelcolvin commented Dec 27, 2018

Change Summary

Validation of dataclasses so they can be nested

Related issue number

fix #273


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes
  • No performance deterioration (if applicable)
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever
Copy link

@codecov codecov bot commented Dec 27, 2018

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #334   +/-   ##
  Coverage     100%   100%           
  Files          13     13           
  Lines        1783   1855   +72     
  Branches      347    378   +31     
+ Hits         1783   1855   +72

@samuelcolvin samuelcolvin force-pushed the dataclass-validation branch from 97cb04c to 70a73d5 Dec 27, 2018
@samuelcolvin samuelcolvin force-pushed the dataclass-validation branch from 4fed94f to 5f00110 Dec 27, 2018
@samuelcolvin samuelcolvin merged commit 8301f9e into master Dec 27, 2018
9 checks passed
@samuelcolvin samuelcolvin deleted the dataclass-validation branch Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant