Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple iterables schema generation #335



Copy link

@nkonin nkonin commented Dec 27, 2018

Change Summary

schema generation for : list, : tuple and : set annotations.

Related issue number


Performance Changes

Not run


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes | It was already in docs, this PR just fix
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever
Copy link

@codecov codecov bot commented Dec 27, 2018

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #335   +/-   ##
  Coverage     100%   100%           
  Files          13     13           
  Lines        1783   1801   +18     
  Branches      347    350    +3     
+ Hits         1783   1801   +18

Copy link

@samuelcolvin samuelcolvin commented Dec 27, 2018

ref #330 and #331.

Copy link

@samuelcolvin samuelcolvin left a comment

otherwise LGTM, @tiangolo?

HISTORY.rst Outdated Show resolved Hide resolved
@samuelcolvin samuelcolvin merged commit e28d689 into samuelcolvin:master Dec 27, 2018
7 checks passed
Copy link

@tiangolo tiangolo commented Dec 28, 2018

Awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants