Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reame get_validators > __get_validators__ #338

merged 2 commits into from Dec 27, 2018


None yet
1 participant
Copy link

samuelcolvin commented Dec 27, 2018

Change Summary

Rename get_validators to __get_validators__ on custom classes to be more like dataclasses (ref #334), also because it's a more sensible name.

Raise a depreciation warning on use of the old name.

We'll remove get_validators usage and warning in future.


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes
  • No performance deterioration (if applicable)
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • if you're not a regular contributer please include your github username @whatever

samuelcolvin added some commits Dec 27, 2018

@samuelcolvin samuelcolvin force-pushed the rename-get_validators branch from c76d609 to ff592dd Dec 27, 2018


This comment has been minimized.

Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #338   +/-   ##
  Coverage     100%   100%           
  Files          13     13           
  Lines        1801   1828   +27     
  Branches      350    369   +19     
+ Hits         1801   1828   +27

@samuelcolvin samuelcolvin merged commit 9ad1a0a into master Dec 27, 2018

5 checks passed

codecov/project 100% (+0%) compared to 0d5cd3b
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!
Details No dependencies with known security vulnerabilities.

@samuelcolvin samuelcolvin deleted the rename-get_validators branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.