Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadd type hints #373
Conversation
samuelcolvin
added some commits
Jan 26, 2019
This comment has been minimized.
This comment has been minimized.
should probably merge other PRs before this to avoid them conflicting. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jan 26, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 1934 1999 +65
Branches 375 375
=====================================
+ Hits 1934 1999 +65 |
samuelcolvin
force-pushed the
typing
branch
from
77eba2b
to
2fabc36
Jan 27, 2019
Jan 29, 2019
This was referenced
Closed
samuelcolvin
added some commits
Feb 4, 2019
samuelcolvin
merged commit 9ef4018
into
master
Feb 4, 2019
5 checks passed
codecov/project
100% (+0%) compared to a853346
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
deploy/netlify
Deploy preview ready!
Details
pyup.io/safety-ci
No dependencies with known security vulnerabilities.
Details
samuelcolvin
deleted the
typing
branch
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
samuelcolvin commentedJan 26, 2019
•
edited
Related issue number
fix #372, fix #366, fix #245, fix #280.
ref python/mypy#6251 and python/mypy#6239
Checklist
HISTORY.rst
has been updated#<number>
@<whomever>