Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type hints #373

Merged
merged 13 commits into from Feb 4, 2019
Merged

add type hints #373

merged 13 commits into from Feb 4, 2019

Conversation

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Jan 26, 2019

Related issue number

fix #372, fix #366, fix #245, fix #280.

ref python/mypy#6251 and python/mypy#6239

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
@samuelcolvin
Copy link
Owner Author

@samuelcolvin samuelcolvin commented Jan 26, 2019

should probably merge other PRs before this to avoid them conflicting.

@codecov
Copy link

@codecov codecov bot commented Jan 26, 2019

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #373   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        1934   1999   +65     
  Branches      375    375           
=====================================
+ Hits         1934   1999   +65

@samuelcolvin samuelcolvin merged commit 9ef4018 into master Feb 4, 2019
9 checks passed
@samuelcolvin samuelcolvin deleted the typing branch Feb 4, 2019
@samuelcolvin samuelcolvin mentioned this pull request Feb 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant