Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type hints #373

merged 13 commits into from Feb 4, 2019


None yet
1 participant
Copy link

samuelcolvin commented Jan 26, 2019

Related issue number

fix #372, fix #366, fix #245, fix #280.

ref python/mypy#6251 and python/mypy#6239


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

samuelcolvin added some commits Jan 26, 2019


This comment has been minimized.

Copy link
Owner Author

samuelcolvin commented Jan 26, 2019

should probably merge other PRs before this to avoid them conflicting.


This comment has been minimized.

Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #373   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        1934   1999   +65     
  Branches      375    375           
+ Hits         1934   1999   +65

samuelcolvin added some commits Feb 4, 2019

@samuelcolvin samuelcolvin merged commit 9ef4018 into master Feb 4, 2019

5 checks passed

codecov/project 100% (+0%) compared to a853346
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!
Details No dependencies with known security vulnerabilities.

@samuelcolvin samuelcolvin deleted the typing branch Feb 4, 2019

@samuelcolvin samuelcolvin referenced this pull request Feb 12, 2019


Tracking for setting attributes #389

1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.