Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom validators in schema #375

merged 2 commits into from Jan 30, 2019


Copy link

@tiangolo tiangolo commented Jan 29, 2019

Change Summary

Test NoneType directly in Field.include_in_schema and add test for validator decorator

Related issue number

Issue #363


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
Copy link

@codecov codecov bot commented Jan 29, 2019

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #375   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        1894   1894           
  Branches      369    369           
  Hits         1894   1894

Copy link
Collaborator Author

@tiangolo tiangolo left a comment


pydantic/ Show resolved Hide resolved
@samuelcolvin samuelcolvin changed the title Fix for #363 custom validators in schema Jan 29, 2019
Copy link
Collaborator Author

@tiangolo tiangolo commented Jan 30, 2019

I just rebased and force pushed to solve the conflicts. This is ready for your review @samuelcolvin .

@samuelcolvin samuelcolvin merged commit 725e86a into samuelcolvin:master Jan 30, 2019
7 checks passed
@tiangolo tiangolo deleted the issue-363 branch Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants