Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom validators in schema #375

merged 2 commits into from Jan 30, 2019


None yet
2 participants
Copy link

tiangolo commented Jan 29, 2019

Change Summary

Test NoneType directly in Field.include_in_schema and add test for validator decorator

Related issue number

Issue #363


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

This comment has been minimized.

Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #375   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        1894   1894           
  Branches      369    369           
  Hits         1894   1894
Copy link
Contributor Author

tiangolo left a comment


Show resolved Hide resolved pydantic/

@samuelcolvin samuelcolvin changed the title Fix for #363 custom validators in schema Jan 29, 2019

@tiangolo tiangolo force-pushed the tiangolo:issue-363 branch from dc31db9 to 7d18346 Jan 30, 2019


This comment has been minimized.

Copy link
Contributor Author

tiangolo commented Jan 30, 2019

I just rebased and force pushed to solve the conflicts. This is ready for your review @samuelcolvin .

@samuelcolvin samuelcolvin merged commit 725e86a into samuelcolvin:master Jan 30, 2019

3 checks passed

codecov/project 100% (+0%) compared to 987449a
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!

@tiangolo tiangolo deleted the tiangolo:issue-363 branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.