Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild validator arguments #388

Merged
merged 3 commits into from Feb 13, 2019
Merged

rebuild validator arguments #388

merged 3 commits into from Feb 13, 2019

Conversation

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Feb 6, 2019

Change Summary

Before now, you either had to use all or none of values, field and config extra arguments on validators. This fixes that by allowing any combination of the arguments to be used.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
@codecov
Copy link

@codecov codecov bot commented Feb 6, 2019

Codecov Report

Merging #388 into master will decrease coverage by 1.62%.
The diff coverage is 54.28%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage     100%   98.37%   -1.63%     
==========================================
  Files          14       14              
  Lines        2000     2034      +34     
  Branches      375      410      +35     
==========================================
+ Hits         2000     2001       +1     
- Misses          0       22      +22     
- Partials        0       11      +11

Repository owner deleted a comment from codecov bot Feb 8, 2019
@codecov
Copy link

@codecov codecov bot commented Feb 8, 2019

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #388   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        2000   2031   +31     
  Branches      375    409   +34     
=====================================
+ Hits         2000   2031   +31

@samuelcolvin samuelcolvin changed the title WIP rebuild validator arguments rebuild validator arguments Feb 8, 2019
@samuelcolvin samuelcolvin merged commit baade9a into master Feb 13, 2019
9 checks passed
@samuelcolvin samuelcolvin deleted the validator-args branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant