Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py.typed marker file for PEP-561 support #391

merged 1 commit into from Feb 13, 2019


Copy link

@je-l je-l commented Feb 10, 2019

Change Summary

PEP-561 specifies way for packages to mark them as having type information. As of v0.19 pydantic has improved inline type hints which can be utilized by mypy and similar tools.

Running python sdist bdist_wheel includes the py.typed file in both distributions.

HISTORY.rst changes needed for this, or something else missing?

Related issue number

Closes #390


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
Fix samuelcolvin#390

Disable zip_safe option as mypy is incompatible with it.
Copy link

@codecov codecov bot commented Feb 10, 2019

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #391   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        2000   2000           
  Branches      375    375           
  Hits         2000   2000

@samuelcolvin samuelcolvin merged commit db53fad into samuelcolvin:master Feb 13, 2019
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants