Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type hint of ValidationError.json #406



Copy link

@layday layday commented Feb 25, 2019

As per the json.dumps documentation.

Change Summary

This changes the type hint of indent to accept any of None, int and str in accordance with the documentation of json.dumps.

Related issue number


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
As per the json.dumps documentation.
Copy link
Contributor Author

@layday layday commented Feb 25, 2019

Not sure if this would be worth mentioning in HISTORY (I would think not).

Copy link

@codecov codecov bot commented Feb 25, 2019

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #406   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        2068   2068           
  Branches      420    420           
  Hits         2068   2068

Copy link

@samuelcolvin samuelcolvin commented Feb 25, 2019

@samuelcolvin samuelcolvin merged commit 0a9b720 into samuelcolvin:master Feb 26, 2019
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants