Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ForwardRef collection bug #450

Merged

Conversation

Projects
None yet
2 participants
@tigerwings
Copy link
Contributor

tigerwings commented Apr 2, 2019

Change Summary

Fix the bug in ForwardRef collection

Related issue number

#439

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #450 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #450   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        2178   2178           
  Branches      434    434           
=====================================
  Hits         2178   2178
a: int = 123
b: Foo = None
a: int = None
b: Dict[str, FooType] = {}

This comment has been minimized.

Copy link
@samuelcolvin

samuelcolvin Apr 2, 2019

Owner

No need to change the example, unless otherwise required examples should be as simple as possible.

@skip_not_37
def test_self_forward_ref_validation(create_module):
module = create_module(
"""

This comment has been minimized.

Copy link
@samuelcolvin

samuelcolvin Apr 2, 2019

Owner

If this string is identical to above, please define it once and reuse.

@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Apr 2, 2019

otherwise looks good.

@samuelcolvin samuelcolvin merged commit 085fc84 into samuelcolvin:master Apr 3, 2019

3 checks passed

codecov/project 100% (+0%) compared to 8406bf0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Apr 3, 2019

great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.