Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ForwardRef collection bug #450



Copy link

@tigerwings tigerwings commented Apr 2, 2019

Change Summary

Fix the bug in ForwardRef collection

Related issue number



  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>
Copy link

@codecov codecov bot commented Apr 2, 2019

Codecov Report

Merging #450 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #450   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        2178   2178           
  Branches      434    434           
  Hits         2178   2178

a: int = 123
b: Foo = None
a: int = None
b: Dict[str, FooType] = {}
Copy link

@samuelcolvin samuelcolvin Apr 2, 2019

No need to change the example, unless otherwise required examples should be as simple as possible.

def test_self_forward_ref_validation(create_module):
module = create_module(
Copy link

@samuelcolvin samuelcolvin Apr 2, 2019

If this string is identical to above, please define it once and reuse.

Copy link

@samuelcolvin samuelcolvin commented Apr 2, 2019

otherwise looks good.

@samuelcolvin samuelcolvin merged commit 085fc84 into samuelcolvin:master Apr 3, 2019
7 checks passed
Copy link

@samuelcolvin samuelcolvin commented Apr 3, 2019

great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants