Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SecretStr and SecretBytes. #452

Merged
merged 9 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@Atheuz
Copy link
Contributor

Atheuz commented Apr 2, 2019

Change Summary

Added SecretStr and SecretBytes.

Related issue number

#443

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
@Atheuz

This comment has been minimized.

Copy link
Contributor Author

Atheuz commented Apr 2, 2019

@samuelcolvin is this better?

@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Apr 2, 2019

Looks like you've changed the permissions on lots of files 100644 → 100755. 😈

Maybe you could set back to 644?

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #452   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        2188   2220   +32     
  Branches      435    435           
=====================================
+ Hits         2188   2220   +32
Show resolved Hide resolved docs/examples/ex_secret_types.py
Show resolved Hide resolved pydantic/schema.py Outdated
Show resolved Hide resolved pydantic/types.py Outdated
Show resolved Hide resolved pydantic/types.py Outdated
Show resolved Hide resolved pydantic/types.py Outdated
Show resolved Hide resolved pydantic/types.py Outdated
Show resolved Hide resolved tests/test_schema.py Outdated
Show resolved Hide resolved tests/test_schema.py Outdated
Show resolved Hide resolved tests/test_types.py Outdated

@Atheuz Atheuz force-pushed the Atheuz:add-secret-types2 branch from e485d56 to d7845a4 Apr 2, 2019

@Atheuz

This comment has been minimized.

Copy link
Contributor Author

Atheuz commented Apr 2, 2019

@samuelcolvin fixed the issues you brought up, but didn't know about the format thing you mentioned.

@Atheuz Atheuz force-pushed the Atheuz:add-secret-types2 branch 2 times, most recently from af54f96 to fec9a1e Apr 2, 2019

@Atheuz Atheuz force-pushed the Atheuz:add-secret-types2 branch from fec9a1e to 6372516 Apr 2, 2019

@LasseGravesen

This comment has been minimized.

Copy link

LasseGravesen commented Apr 3, 2019

@samuelcolvin are we mergable yet?

@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Apr 3, 2019

Just waiting for a response from @tiangolo, on the question above, I've done some research but not entirely clear.

Is this particularly urgent for you?

@tiangolo

This comment has been minimized.

Copy link
Contributor

tiangolo commented Apr 3, 2019

Sorry for the delay guys. I hadn't seen the notification. I added my comment in the conversation above.

@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Apr 3, 2019

thanks @tiangolo, much appreciated.

No problem on the slight delay, still better than the response time for most paid services. :-)

LasseGravesen and others added some commits Apr 3, 2019

@tiangolo
Copy link
Contributor

tiangolo left a comment

Great! This looks very useful.

I added a couple of suggestions related to JSON Schema.

Show resolved Hide resolved pydantic/schema.py Outdated
Show resolved Hide resolved pydantic/schema.py Outdated
Show resolved Hide resolved docs/schema_mapping.py Outdated
Show resolved Hide resolved docs/schema_mapping.py Outdated
@tiangolo
Copy link
Contributor

tiangolo left a comment

Just a couple of things I forgot to mention in docs.

Show resolved Hide resolved docs/schema_mapping.py Outdated
Show resolved Hide resolved docs/schema_mapping.py Outdated

Atheuz and others added some commits Apr 4, 2019

@tiangolo
Copy link
Contributor

tiangolo left a comment

Great! LGTM

@samuelcolvin samuelcolvin merged commit 4a8faca into samuelcolvin:master Apr 4, 2019

3 checks passed

codecov/project 100% (+0%) compared to 694abaf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.