Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classvars #455

merged 7 commits into from Apr 3, 2019


None yet
2 participants
Copy link

samuelcolvin commented Apr 3, 2019

replaces #442

Change Summary

This adds support for parametrized ClassVars in a model.

Related issue number



  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

tyrylu and others added some commits Mar 29, 2019

Use apostrophes and pass the test also on python 3.6, where ClassVar[…
…int] is a ClassVar, not a _GenericAlias. Note that the == operator gives False in this case, so we must really compare the classes directly.

This comment has been minimized.

Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #455 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #455   +/-   ##
  Coverage     100%   100%           
  Files          14     14           
  Lines        2178   2182    +4     
  Branches      434    434           
+ Hits         2178   2182    +4

@samuelcolvin samuelcolvin merged commit bbbc898 into master Apr 3, 2019

5 checks passed

codecov/project 100% (+0%) compared to 085fc84
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!
Details No dependencies with known security vulnerabilities.

@samuelcolvin samuelcolvin deleted the classvars branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.