New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DRF Benchmark #47

Merged
merged 1 commit into from Jun 12, 2017

Conversation

2 participants
@mgu
Contributor

mgu commented Jun 12, 2017

No description provided.

@samuelcolvin

This comment has been minimized.

Owner

samuelcolvin commented Jun 12, 2017

Awsome, thank you. What are the results?

@mgu

This comment has been minimized.

Contributor

mgu commented Jun 12, 2017

trafaret   best=1.391s, avg=1.402s, stdev=0.013s
drf        best=6.006s, avg=6.153s, stdev=0.183s
pydantic   best=0.678s, avg=0.694s, stdev=0.014s

:)

@codecov

This comment has been minimized.

codecov bot commented Jun 12, 2017

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #47   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         701    701           
  Branches      156    156           
=====================================
  Hits          701    701
@samuelcolvin

This comment has been minimized.

Owner

samuelcolvin commented Jun 12, 2017

wow, that's not great of drf. But having read its code in the past it, it does masses of checking that it's configured right and calls out to slow django standard methods.

I'll have a play with it later and merge.

@mgu

This comment has been minimized.

Contributor

mgu commented Jun 12, 2017

ok, thanks

@samuelcolvin

This comment has been minimized.

Owner

samuelcolvin commented Jun 12, 2017

Looks good. I'm shocked by the performance gap.

I'll try to add a few more popular packages and then perhaps add a graph of relative performance to the docs.

@samuelcolvin samuelcolvin merged commit 8364a6b into samuelcolvin:master Jun 12, 2017

2 checks passed

codecov/project 100% remains the same compared to 85795a7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment