Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dict with extra keys #490

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@JaewonKim
Copy link
Contributor

commented Apr 24, 2019

Change Summary

This will fix key error that occurs when calling model.dict(by_alias=True) with the model contains extra keys.

Related issue number

Resolves #488

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@JaewonKim JaewonKim changed the title Fix dict with extra keys (#489) Fix dict with extra keys (#490) Apr 24, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #490 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #490   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        2251   2251           
  Branches      443    443           
=====================================
  Hits         2251   2251

@JaewonKim JaewonKim changed the title Fix dict with extra keys (#490) Fix dict with extra keys Apr 24, 2019

@samuelcolvin
Copy link
Owner

left a comment

otherwise LGTM.

Show resolved Hide resolved tests/test_main.py Outdated

@samuelcolvin samuelcolvin merged commit a3d9ad1 into samuelcolvin:master Apr 25, 2019

4 of 7 checks passed

Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% (+0%) compared to e5b8ec7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.