Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type hint for create_model #526

Merged
merged 3 commits into from May 16, 2019

Conversation

@dmontagu
Copy link
Collaborator

@dmontagu dmontagu commented May 16, 2019

Described in #525

Change Summary

Fix the return type of create_model

Related issue number

Issue #525

@codecov
Copy link

@codecov codecov bot commented May 16, 2019

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #526   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        2272   2272           
  Branches      448    448           
=====================================
  Hits         2272   2272

@samuelcolvin samuelcolvin merged commit 9b98d14 into samuelcolvin:master May 16, 2019
7 checks passed
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented May 16, 2019

Thanks so much.

gangefors added a commit to gangefors/pydantic that referenced this issue May 31, 2019
* upstream/master: (138 commits)
  add 'none-any.whl' to pypi upload (samuelcolvin#564)
  uprev
  update benchmarks (samuelcolvin#563)
  cython (samuelcolvin#548)
  Fix issue with unspecified generic type (samuelcolvin#554)
  Run dataclass' original __post_init__ before validation (samuelcolvin#560)
  try to stop annoying warnings in azure pipeline (samuelcolvin#549)
  azure pipeline failOnStderr: false
  Azure Pipelines - tests for windows (samuelcolvin#538)
  Fix JSON Schema for list, tuple, and set, improving interoperability (samuelcolvin#540)
  uprev.
  Colors (samuelcolvin#516)
  Fix to schema generation for IPv{4,6}{Address,Interface,Network} (samuelcolvin#532)
  Fix __fields_set__ not using alias field names (samuelcolvin#517) (samuelcolvin#518)
  Change return type hint for create_model (samuelcolvin#526)
  Tuple ellipsis (samuelcolvin#512)
  Fix to schema generation for IPvAny{Address,Interface,Network} (samuelcolvin#498) (samuelcolvin#510)
  uprev
  Scheduled monthly dependency update for May (samuelcolvin#499)
  Implement const keyword in Schema. (samuelcolvin#469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants