Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #608 (repr on model with class) #611

merged 4 commits into from Jun 26, 2019


None yet
2 participants
Copy link

commented Jun 21, 2019

Change Summary

Handle the case where pydantic.utils.truncate is called on a type.

Related issue number

fix #608


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
Show resolved Hide resolved pydantic/ Outdated

This comment has been minimized.

Copy link

commented Jun 21, 2019

Codecov Report

Merging #611 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #611   +/-   ##
  Coverage     100%   100%           
  Files          15     15           
  Lines        2613   2585   -28     
  Branches      516    510    -6     
- Hits         2613   2585   -28

@dmontagu dmontagu force-pushed the dmontagu:fix-repr branch from 4d03a08 to 292086d Jun 21, 2019

David Montague added some commits Jun 21, 2019

David Montague

@dmontagu dmontagu force-pushed the dmontagu:fix-repr branch from 292086d to cd4fa79 Jun 23, 2019

David Montague

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

Quotes linting in the build saved me, thanks again for adding this @samuelcolvin !

@samuelcolvin samuelcolvin merged commit ccdf8e1 into samuelcolvin:master Jun 26, 2019

5 of 8 checks passed

Header rules No header rules processed
Pages changed 1 new file uploaded
Redirect rules No redirect rules processed
LGTM analysis: Python No new or fixed alerts
Mixed content No mixed content detected
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!
samuelcolvin.pydantic Build #20190625.4 succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.