New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias_generator #622
Merged
Merged
Add alias_generator #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2628 2634 +6
Branches 516 518 +2
=====================================
+ Hits 2628 2634 +6 |
samuelcolvin
reviewed
Jun 27, 2019
Otherwise mostly looks good to me.
How do we cope with #624 which I hope to implement soon? Three different functions or the method could alternatively return a 3-tuple? Either of these solutions could be implemented later and would be backwards compatible.
Move docs to config section, reformat example Separate test_alias_generator
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
…fig.alias_generator Add one more condition for applying alias_generator Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
great, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change Summary
Add
Config.alias_generator
that provides ability to convert name to alias for each field of model. See docs example:Related issue number
None
Checklist
HISTORY.rst
has been updated