Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unparameterized generic type schema generation #625

Merged
merged 5 commits into from Jul 2, 2019

Conversation

Projects
None yet
2 participants
@dmontagu
Copy link
Contributor

commented Jun 27, 2019

Change Summary

Fixes #623 as described by @samuelcolvin (unparameterized generic types will not have restrictions on the parameterized types).

Related issue number

#623

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@dmontagu dmontagu force-pushed the dmontagu:fix-partial-type-schema branch from 38506ff to af99c21 Jun 27, 2019

David Montague

@dmontagu dmontagu changed the title Fix #623 Fix unparameterized generic type schema generation Jun 27, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #625   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2628   2628           
  Branches      516    516           
=====================================
  Hits         2628   2628

David Montague added some commits Jun 27, 2019

David Montague
David Montague
@codecov

This comment has been minimized.

Copy link

commented Jun 28, 2019

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #625   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2628   2628           
  Branches      516    516           
=====================================
  Hits         2628   2628

@samuelcolvin samuelcolvin merged commit 8aac71a into samuelcolvin:master Jul 2, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
LGTM analysis: Python No new or fixed alerts
Details
Mixed content No mixed content detected
Details
codecov/project 100% (+0%) compared to 3cdbbae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20190628.5 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.