Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter the behaviour of dict(model) so that sub-models are nolonger converted to dictionaries #733

Merged
merged 3 commits into from Aug 12, 2019

Conversation

samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Aug 10, 2019

Change Summary

dict(model) as well as for name, value in model: now don't convert sub-models to dictionaries.

I've also completely rewritten the dict(), json(), copy(), pickle() section of the docs.

Related issue number

Fix #508

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • change description file added to changes/ called <pull request or issue id>-<github username>.rst,
    see changes/README.md for details
    on the format

@samuelcolvin samuelcolvin changed the title fix iteration to not convert to dict by default alter the behaviour of dict(model) so that sub-models are nolonger converted to dictionaries Aug 10, 2019
@codecov
Copy link

@codecov codecov bot commented Aug 10, 2019

Codecov Report

Merging #733 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #733   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2718   2718           
  Branches      534    534           
=====================================
  Hits         2718   2718

@samuelcolvin samuelcolvin merged commit 82ef45c into master Aug 12, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the fix-iteration branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant