Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter the behaviour of dict(model) so that sub-models are nolonger converted to dictionaries #733

merged 3 commits into from Aug 12, 2019


Copy link

samuelcolvin commented Aug 10, 2019

Change Summary

dict(model) as well as for name, value in model: now don't convert sub-models to dictionaries.

I've also completely rewritten the dict(), json(), copy(), pickle() section of the docs.

Related issue number

Fix #508


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • change description file added to changes/ called <pull request or issue id>-<github username>.rst,
    see changes/ for details
    on the format
@samuelcolvin samuelcolvin changed the title fix iteration to not convert to dict by default alter the behaviour of dict(model) so that sub-models are nolonger converted to dictionaries Aug 10, 2019

This comment has been minimized.

Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #733 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #733   +/-   ##
  Coverage     100%   100%           
  Files          15     15           
  Lines        2718   2718           
  Branches      534    534           
  Hits         2718   2718
@samuelcolvin samuelcolvin merged commit 82ef45c into master Aug 12, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Pages changed All files already uploaded
Redirect rules No redirect rules processed
Mixed content No mixed content detected
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!
Details No dependencies with known security vulnerabilities.
samuelcolvin.pydantic Build #20190812.4 succeeded
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
@samuelcolvin samuelcolvin deleted the fix-iteration branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.