Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom Schema on GenericModel fields #754

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@amitbl
Copy link

commented Aug 16, 2019

Change Summary

Fix custom Schema definitions on fields of GenericModel subclasses being ignored

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
amitbl added 2 commits Aug 16, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 16, 2019

Codecov Report

Merging #754 into v0.32.x will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v0.32.x     #754      +/-   ##
===========================================
- Coverage      100%   99.92%   -0.08%     
===========================================
  Files           15       15              
  Lines         2733     2733              
  Branches       543      543              
===========================================
- Hits          2733     2731       -2     
- Misses           0        2       +2
@dmontagu

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

Looks good to me

@samuelcolvin samuelcolvin merged commit 0f6e296 into samuelcolvin:v0.32.x Aug 17, 2019

7 of 10 checks passed

Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 99.92% (-0.08%) compared to e5e1b95
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20190816.21 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.