Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom Schema on GenericModel fields #754

Merged
merged 2 commits into from Aug 17, 2019

Conversation

amitbl
Copy link

@amitbl amitbl commented Aug 16, 2019

Change Summary

Fix custom Schema definitions on fields of GenericModel subclasses being ignored

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%

@codecov
Copy link

@codecov codecov bot commented Aug 16, 2019

Codecov Report

Merging #754 into v0.32.x will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v0.32.x     #754      +/-   ##
===========================================
- Coverage      100%   99.92%   -0.08%     
===========================================
  Files           15       15              
  Lines         2733     2733              
  Branches       543      543              
===========================================
- Hits          2733     2731       -2     
- Misses           0        2       +2

@dmontagu
Copy link
Collaborator

@dmontagu dmontagu commented Aug 16, 2019

Looks good to me

@samuelcolvin samuelcolvin merged commit 0f6e296 into samuelcolvin:v0.32.x Aug 17, 2019
10 checks passed
samuelcolvin added a commit that referenced this issue Oct 1, 2019
* fix(validate-assignment): do not validate extra fields when `vaidate_assignment` is on

* Update history

* Fix `value` vs. `value_`

* Add tests for `value` vs `value_` case

* uprev

* Fix generic required (#742)

* Fix required fields on GenericModel

* lint

* version up

* __post_init__ with inheritance, fix #739 (#740)

* Fix custom Schema on GenericModel fields (#754)

* Fix custom Schema on GenericModel fields

* Add PR#

* uprev

* Fix error messages for Literal types with multiple allowed values (#770)

* Fix error messages for Literal types with multiple allowed values

* Incorporate feedback

* update history
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* fix(validate-assignment): do not validate extra fields when `vaidate_assignment` is on

* Update history

* Fix `value` vs. `value_`

* Add tests for `value` vs `value_` case

* uprev

* Fix generic required (samuelcolvin#742)

* Fix required fields on GenericModel

* lint

* version up

* __post_init__ with inheritance, fix samuelcolvin#739 (samuelcolvin#740)

* Fix custom Schema on GenericModel fields (samuelcolvin#754)

* Fix custom Schema on GenericModel fields

* Add PR#

* uprev

* Fix error messages for Literal types with multiple allowed values (samuelcolvin#770)

* Fix error messages for Literal types with multiple allowed values

* Incorporate feedback

* update history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants