Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small performance improvements to validators and fields #763

merged 7 commits into from Aug 18, 2019


Copy link

@samuelcolvin samuelcolvin commented Aug 18, 2019

Change Summary

Shape is no longer an enum, signatures of anystr_strip_whitespace and anystr_length_validator are corrected.


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable NA
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/ for details)

@samuelcolvin samuelcolvin force-pushed the tiny-performance-improvements branch from 4f1bb4f to c0386db Compare Aug 18, 2019
Repository owner deleted a comment from codecov bot Aug 18, 2019
Copy link
Owner Author

@samuelcolvin samuelcolvin commented Aug 18, 2019

turns out this performance improvements aren't so small, ended up at 10-15% improvement on benchmarks.

Copy link

@codecov codecov bot commented Aug 18, 2019

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #763   +/-   ##
  Coverage     100%   100%           
  Files          15     15           
  Lines        2726   2729    +3     
  Branches      537    539    +2     
+ Hits         2726   2729    +3

@samuelcolvin samuelcolvin force-pushed the tiny-performance-improvements branch from c729c66 to b9e3eef Compare Aug 18, 2019
@samuelcolvin samuelcolvin merged commit 0e8cfba into master Aug 18, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the tiny-performance-improvements branch Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant