New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaymentCardNumber type #790
Conversation
@samuelcolvin How does the code look to you? |
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 2889 2972 +83
Branches 568 578 +10
=====================================
+ Hits 2889 2972 +83
Continue to review full report at Codecov.
|
@dmontagu thanks for the help! |
In general looks good, a few things to fix and please add docs.
changes/790-matin.rst
Outdated
@@ -0,0 +1 @@ | |||
add the `PaymentCardNumber` type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the `PaymentCardNumber` type | |
add the ``PaymentCardNumber`` type |
This is rst :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs changing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matin this still neds to change.
oh, and conflicts. |
changes/790-matin.rst
Outdated
@@ -0,0 +1 @@ | |||
add the `PaymentCardNumber` type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs changing.
Awesome. Thank you. |
Change Summary
Validation of payment card numbers.
Related issue number
closes #788
Checklist
changes/<pull request or issue id>-<github username>.rst
file added describing change(see changes/README.md for details)