PaymentCardNumber type #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuelcolvin How does the code look to you? |
matin
reviewed
Sep 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 2889 2972 +83
Branches 568 578 +10
=====================================
+ Hits 2889 2972 +83
Continue to review full report at Codecov.
|
dmontagu
reviewed
Sep 1, 2019
dmontagu
reviewed
Sep 1, 2019
|
@dmontagu thanks for the help! |
samuelcolvin
reviewed
Sep 2, 2019
changes/790-matin.rst
Outdated
| @@ -0,0 +1 @@ | |||
| add the `PaymentCardNumber` type | |||
There was a problem hiding this comment.
Suggested change
| add the `PaymentCardNumber` type | |
| add the ``PaymentCardNumber`` type |
This is rst :-)
There was a problem hiding this comment.
Hi @matin this still neds to change.
|
oh, and conflicts. |
samuelcolvin
reviewed
Sep 15, 2019
samuelcolvin
reviewed
Sep 16, 2019
|
Awesome. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change Summary
Validation of payment card numbers.
Related issue number
closes #788
Checklist
changes/<pull request or issue id>-<github username>.rstfile added describing change(see changes/README.md for details)