Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaymentCardNumber type #790

Merged
merged 31 commits into from Sep 17, 2019
Merged

PaymentCardNumber type #790

merged 31 commits into from Sep 17, 2019

Conversation

matin
Copy link
Contributor

@matin matin commented Sep 1, 2019

Change Summary

Validation of payment card numbers.

Related issue number

closes #788

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@matin
Copy link
Contributor Author

@matin matin commented Sep 1, 2019

@samuelcolvin How does the code look to you?

pydantic/types.py Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Sep 1, 2019

Codecov Report

Merging #790 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #790   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines        2889   2972   +83     
  Branches      568    578   +10     
=====================================
+ Hits         2889   2972   +83
Impacted Files Coverage Δ
pydantic/types.py 100% <100%> (ø) ⬆️
pydantic/errors.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08fd2f...c667047. Read the comment docs.

pydantic/types.py Outdated Show resolved Hide resolved
pydantic/types.py Outdated Show resolved Hide resolved
@matin
Copy link
Contributor Author

@matin matin commented Sep 1, 2019

@dmontagu thanks for the help!

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

In general looks good, a few things to fix and please add docs.

@@ -0,0 +1 @@
add the `PaymentCardNumber` type
Copy link
Owner

@samuelcolvin samuelcolvin Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add the `PaymentCardNumber` type
add the ``PaymentCardNumber`` type

This is rst :-)

Copy link
Contributor Author

@matin matin Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do!

Copy link
Owner

@samuelcolvin samuelcolvin Sep 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs changing.

Copy link
Owner

@samuelcolvin samuelcolvin Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matin this still neds to change.

pydantic/types.py Show resolved Hide resolved
pydantic/types.py Show resolved Hide resolved
pydantic/types.py Outdated Show resolved Hide resolved
Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Just a few more small things, sorry to be a pedant.

pydantic/errors.py Outdated Show resolved Hide resolved
pydantic/errors.py Outdated Show resolved Hide resolved
pydantic/types.py Outdated Show resolved Hide resolved
tests/test_types_payment_card_number.py Outdated Show resolved Hide resolved
tests/test_types_payment_card_number.py Outdated Show resolved Hide resolved
tests/test_types_payment_card_number.py Outdated Show resolved Hide resolved
tests/test_types_payment_card_number.py Outdated Show resolved Hide resolved
tests/test_types_payment_card_number.py Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Sep 3, 2019

oh, and conflicts.

@@ -0,0 +1 @@
add the `PaymentCardNumber` type
Copy link
Owner

@samuelcolvin samuelcolvin Sep 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs changing.

pydantic/types.py Outdated Show resolved Hide resolved
pydantic/types.py Outdated Show resolved Hide resolved
docs/examples/payment_card_number.py Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
@samuelcolvin samuelcolvin merged commit 0c57937 into samuelcolvin:master Sep 17, 2019
10 checks passed
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Sep 17, 2019

Awesome. Thank you.

@samuelcolvin samuelcolvin mentioned this pull request Jan 15, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants