Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set additionalProperties to False on Extra.forbid models #796

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@Code0x58
Copy link
Contributor

Code0x58 commented Sep 7, 2019

Change Summary

Set "additionalProperties": False on schema for models with Config.extra == Extra.forbid.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/796-Code0x58.rst file added describing change
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #796 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage     100%   99.92%   -0.08%     
==========================================
  Files          17       17              
  Lines        2846     2848       +2     
  Branches      559      560       +1     
==========================================
  Hits         2846     2846              
- Misses          0        2       +2
Impacted Files Coverage Δ
pydantic/schema.py 100% <100%> (ø) ⬆️
pydantic/main.py 99.48% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7901711...b0ab8a2. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 830278b into samuelcolvin:master Sep 9, 2019
10 checks passed
10 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project Absolute coverage decreased by -0.07% but relative coverage remained the same compared to 7901711
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20190907.5 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Sep 9, 2019

great, thanks.

@Code0x58 Code0x58 deleted the Code0x58:model-extra-forbid branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.