Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNone behaviour #803
Merged
None behaviour #803
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Sep 10, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 2985 2989 +4
Branches 580 583 +3
=====================================
+ Hits 2985 2989 +4
Continue to review full report at Codecov.
|
This was referenced Sep 11, 2019
This comment has been minimized.
This comment has been minimized.
This is ready for review. @dmontagu @tiangolo and anyone else interested: would be great if you could review. Significant changes:
There are a few other tweaks, but nothing that should effect end users. |
Merged
LGTM |
This was referenced Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
samuelcolvin commentedSep 10, 2019
•
edited
Checklist
changes/<pull request or issue id>-<github username>.rst
file added describing change(see changes/README.md for details)