Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change how env variables work with settings #847

Merged
merged 4 commits into from Oct 1, 2019
Merged

change how env variables work with settings #847

merged 4 commits into from Oct 1, 2019

Conversation

samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Oct 1, 2019

Change Summary

  • add prepare_field hook on Config
  • use env not aliases to define which environment variable(s) settings respects

Related issue number

#721

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@codecov
Copy link

@codecov codecov bot commented Oct 1, 2019

Codecov Report

Merging #847 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files          17       17              
  Lines        3099     3124      +25     
  Branches      598      606       +8     
==========================================
+ Hits         3097     3122      +25     
  Misses          2        2
Impacted Files Coverage Δ
pydantic/main.py 100% <100%> (ø) ⬆️
pydantic/fields.py 100% <100%> (ø) ⬆️
pydantic/env_settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f4e0d...3000185. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 9a5b411 into master Oct 1, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the settings-env branch Oct 1, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* change how env variables work with settings, fix samuelcolvin#721

* inheritance and alias warnings

* update docs

* tweak env_settings.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant