Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bits of cleanup #851

merged 4 commits into from Oct 1, 2019

small bits of cleanup #851

merged 4 commits into from Oct 1, 2019


Copy link

samuelcolvin commented Oct 1, 2019

  • rename a few internal things in
  • correct coverage for GetterDict
  • fix user and password properties of AnyUrl


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/ for details)
samuelcolvin added 2 commits Oct 1, 2019

This comment has been minimized.

Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #851 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #851      +/-   ##
+ Coverage   99.93%   100%   +0.06%     
  Files          17     17              
  Lines        3099   3379     +280     
  Branches      598    756     +158     
+ Hits         3097   3379     +282     
+ Misses          2      0       -2
Impacted Files Coverage Δ
pydantic/ 100% <ø> (ø) ⬆️
pydantic/ 100% <100%> (ø) ⬆️
pydantic/ 100% <0%> (ø) ⬆️
pydantic/ 100% <0%> (ø) ⬆️
pydantic/ 100% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce16ed...90978d3. Read the comment docs.

@samuelcolvin samuelcolvin changed the title small tweaks to small bits of cleanup Oct 1, 2019
@samuelcolvin samuelcolvin merged commit 8f29837 into master Oct 1, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Pages changed All files already uploaded
Redirect rules No redirect rules processed
Mixed content No mixed content detected
codecov/project 100% (+0.06%) compared to 3ce16ed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!
samuelcolvin.pydantic Build #20191001.28 succeeded
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
@samuelcolvin samuelcolvin deleted the main-tweaks branch Oct 1, 2019
cuencandres added a commit to cuenca-mx/pydantic that referenced this pull request Jan 17, 2020
* small tweaks to

* add changes

* correct ModelMetaclass name

* fix password and user on AnyUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.