Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAutomatically add no-cover to TYPE_CHECKING blocks #874
Conversation
2 commits
Oct 7, 2019
added
This comment has been minimized.
This comment has been minimized.
I noticed this while working on #873, but assumed it would be better to put it in a separate PR. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 7, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2716 2716
Branches 518 518
=====================================
Hits 2716 2716
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
425fac6
into
samuelcolvin:master
10 checks passed
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dmontagu commentedOct 7, 2019
•
edited
Change Summary
Adds
if TYPE_CHECKING:
to the exclude_lines for coverage so that the# pragma: no cover
can be removed everywhere it occurs next to anif TYPE_CHECKING:
block.Note: this is safe since code inside such blocks should never be executed except during static analysis.
Checklist
changes/<pull request or issue id>-<github username>.rst
file added describing change(see changes/README.md for details)