Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename allow_population_by_alias -> allow_population_by_field_name #875

Merged
merged 4 commits into from Oct 7, 2019

Conversation

@samuelcolvin
Copy link
Owner

samuelcolvin commented Oct 7, 2019

Related issue number

fix #585

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
samuelcolvin added 2 commits Oct 7, 2019
@samuelcolvin samuelcolvin mentioned this pull request Oct 7, 2019
5 of 5 tasks complete
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #875 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #875   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2716           
  Branches      518    518           
=====================================
  Hits         2716   2716

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b7d52...a293ad1. Read the comment docs.

@samuelcolvin samuelcolvin requested a review from dmontagu Oct 7, 2019
@dmontagu

This comment has been minimized.

Copy link
Collaborator

dmontagu commented Oct 7, 2019

Looks good to me!


Out of curiosity -- do you have a timeline in mind for when the "deprecated" warning will become an error?

@samuelcolvin

This comment has been minimized.

Copy link
Owner Author

samuelcolvin commented Oct 7, 2019

Out of curiosity -- do you have a timeline in mind for when the "deprecated" warning will become an error?

Not really, I didn't really want to add them to v1, but @tiangolo asked me to include them.

Perhaps 4 months or v1.2 whichever takes longer?

@samuelcolvin samuelcolvin merged commit ae34a6a into master Oct 7, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% remains the same compared to 33b7d52
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20191007.51 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin samuelcolvin deleted the allow-pop-by-name branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.