Skip to content

/pydantic

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field of a type that has a default value #880

Merged
merged 4 commits into from Oct 9, 2019
Merged

Fix field of a type that has a default value #880

merged 4 commits into from Oct 9, 2019

Conversation

@koxudaxi
Copy link
Contributor

koxudaxi commented Oct 8, 2019 •
edited

Change Summary

The PR fixes the field of a type that has a default value.

Related issue number

#878

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
@koxudaxi
fix type field
Loading status checks…
abb3b40
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Oct 8, 2019 •
edited

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #880   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2716           
  Branches      518    518           
=====================================
  Hits         2716   2716

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0e531...a5de5c9. Read the comment docs.
@koxudaxi koxudaxi changed the title Fix type field with default value Fix field of a type that has a default value Oct 8, 2019
@koxudaxi
update changes
Loading status checks…
e2c70e1
@dmontagu
dmontagu reviewed Oct 8, 2019
View changes
tests/test_edge_cases.py Show resolved Hide resolved
@koxudaxi
add testcase
Loading status checks…
4c41dd3
@samuelcolvin
samuelcolvin reviewed Oct 9, 2019
View changes
Copy link
Owner

samuelcolvin left a comment

otherwise LGTM.
tests/test_edge_cases.py Show resolved Hide resolved
@koxudaxi
separate test for type fields
Loading status checks…
a5de5c9
@koxudaxi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

koxudaxi commented Oct 9, 2019

I have separated the test.
@samuelcolvin samuelcolvin merged commit 46db1ef into samuelcolvin:master Oct 9, 2019
10 checks passed
10 checks passed
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% remains the same compared to 6a0e531
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20191009.2 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin

This comment has been minimized.

Sign in to view
Copy link
Owner

samuelcolvin commented Oct 9, 2019

great, thank you.
@koxudaxi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

koxudaxi commented Oct 9, 2019

Thank you!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin

@dmontagu dmontagu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@koxudaxi @samuelcolvin @dmontagu
You can’t perform that action at this time.