Fix field of a type that has a default value #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2716 2716
Branches 518 518
=====================================
Hits 2716 2716Continue to review full report at Codecov.
|
koxudaxi
changed the title
dmontagu
reviewed
Oct 8, 2019
|
I have separated the test. |
|
great, thank you. |
|
Thank you!! |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this issue
Jan 17, 2020
* fix type field * update changes * add testcase * separate test for type fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change Summary
The PR fixes the field of a type that has a default value.
Related issue number
#878
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)