Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FutureWarning in settings so it's printed #881

Merged
merged 5 commits into from Oct 10, 2019

Conversation

samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Oct 9, 2019

Change Summary

Use FutureWarning instead of DeprecationWarning when aliases rather than env are used for settings.

This is because DeprecationWarning is not printed to stderr by default, making this warning invisible.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

@codecov codecov bot commented Oct 9, 2019

Codecov Report

Merging #881 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #881   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2716           
  Branches      518    518           
=====================================
  Hits         2716   2716
Impacted Files Coverage Δ
pydantic/env_settings.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dd39c...c89821c. Read the comment docs.

@samuelcolvin samuelcolvin merged commit bd8918b into master Oct 10, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the FutureWarning-in-settings branch Oct 10, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* use FutureWarning in settings so it's printed

* fix tests

* better warning link

* change warning link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant