Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Model.fields for Model.__fields__ #883

Merged
merged 3 commits into from Oct 11, 2019
Merged

Conversation

@samuelcolvin
Copy link
Owner

samuelcolvin commented Oct 9, 2019

Change Summary

deprecated the Model.fields property, use Model.__fields__ instead

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
@samuelcolvin samuelcolvin changed the title deprecate Model.fields, use Model.__fields__ deprecate Model.fields for Model.__fields__ Oct 9, 2019
@samuelcolvin samuelcolvin force-pushed the deprecate-model-fields branch from 0c9d3b8 to 149034e Oct 9, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #883   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2720    +4     
  Branches      518    521    +3     
=====================================
+ Hits         2716   2720    +4
Impacted Files Coverage Δ
pydantic/env_settings.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dd39c...b0223e9. Read the comment docs.

@samuelcolvin

This comment has been minimized.

Copy link
Owner Author

samuelcolvin commented Oct 10, 2019

.fields was really dumb, in particular it didn't work from a model, only a model instance. This is a breaking change, but I think worth if for such an correction.

@ashears

This comment has been minimized.

Copy link
Contributor

ashears commented Oct 11, 2019

The new usage is more logical to me.

@samuelcolvin samuelcolvin merged commit d0c6ec7 into master Oct 11, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% remains the same compared to f3dd39c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20191010.18 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin samuelcolvin deleted the deprecate-model-fields branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.