Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warning for case_insensitive on BaseSettings config #885

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@samuelcolvin
Copy link
Owner

samuelcolvin commented Oct 10, 2019

This is just adding a deprecation warning and use the value of case_insensitive which was removed on #721.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #885 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #885   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2716   2716           
  Branches      518    518           
=====================================
  Hits         2716   2716

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d79de...90df598. Read the comment docs.

@samuelcolvin samuelcolvin changed the title deprecate case_insensitive on BaseSettings config deprecation warning for case_insensitive on BaseSettings config Oct 10, 2019
@samuelcolvin samuelcolvin merged commit d381fe8 into master Oct 11, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% remains the same compared to 41d79de
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20191010.20 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin samuelcolvin deleted the deprecate-case_insensitive branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.