Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for bool to match code #911

Merged
merged 2 commits into from Oct 17, 2019
Merged

Conversation

@Trim21
Copy link
Contributor

Trim21 commented Oct 17, 2019

Change Summary

Update docs for usage/types/#booleans

a str which when converted to lower case is one of 'off', 'f', 'false', 'n', 'no', '1', 'on', 't', 'true', 'y', 'yes'

Missing value '0' in code

BOOL_FALSE = {0, '0', 'off', 'f', 'false', 'n', 'no'}

Related issue number

No

Checklist

  • [ ] Unit tests for the changes exist not changing any code.
  • [ ] Tests pass on CI and coverage remains at 100% not changing any code.
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
Trim21 added 2 commits Oct 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #911   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2751   2751           
  Branches      523    523           
=====================================
  Hits         2751   2751

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7b216...de2c2bf. Read the comment docs.

@samuelcolvin samuelcolvin merged commit afba60f into samuelcolvin:master Oct 17, 2019
10 checks passed
10 checks passed
Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% remains the same compared to ed7b216
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20191017.21 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Oct 17, 2019

great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.