Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better str and repr for ModelField #912

Merged
merged 6 commits into from Oct 18, 2019
Merged

better str and repr for ModelField #912

merged 6 commits into from Oct 18, 2019

Conversation

samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Oct 17, 2019

Change Summary

Better str/repr logic for ModelField

Related issue number

fix #505

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

@codecov codecov bot commented Oct 17, 2019

Codecov Report

Merging #912 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #912   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2751   2766   +15     
  Branches      523    528    +5     
=====================================
+ Hits         2751   2766   +15
Impacted Files Coverage Δ
pydantic/utils.py 100% <100%> (ø) ⬆️
pydantic/fields.py 100% <100%> (ø) ⬆️
pydantic/typing.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2427f63...8da038f. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 78921da into master Oct 18, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the better-field-repr branch Oct 18, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* better str and repr for ModelField, fix samuelcolvin#505

* better type display, fix tests

* correct _type_display signature

* fix for python3.6 differences

* fix PyObjectStr

* fix coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant