Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better str and repr for ModelField #912

Merged
merged 6 commits into from Oct 18, 2019
Merged

better str and repr for ModelField #912

merged 6 commits into from Oct 18, 2019

Conversation

@samuelcolvin
Copy link
Owner

samuelcolvin commented Oct 17, 2019

Change Summary

Better str/repr logic for ModelField

Related issue number

fix #505

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
@samuelcolvin samuelcolvin force-pushed the better-field-repr branch from 531e89f to 8d883a6 Oct 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #912 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #912   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2751   2766   +15     
  Branches      523    528    +5     
=====================================
+ Hits         2751   2766   +15
Impacted Files Coverage Δ
pydantic/utils.py 100% <100%> (ø) ⬆️
pydantic/fields.py 100% <100%> (ø) ⬆️
pydantic/typing.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2427f63...8da038f. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 78921da into master Oct 18, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Details
Pages changed 5 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/project 100% (+0%) compared to 2427f63
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
samuelcolvin.pydantic Build #20191018.7 succeeded
Details
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
Details
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
Details
@samuelcolvin samuelcolvin deleted the better-field-repr branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.