Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstrainedList improvements #917

Merged
merged 1 commit into from Oct 21, 2019
Merged

ConstrainedList improvements #917

merged 1 commit into from Oct 21, 2019

Conversation

samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Oct 21, 2019

Change Summary

fix #913, replace #914

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@samuelcolvin samuelcolvin changed the title ConstrainedList improvements, ConstrainedList improvements Oct 21, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 21, 2019

Codecov Report

Merging #917 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #917   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2791   2799    +8     
  Branches      540    543    +3     
=====================================
+ Hits         2791   2799    +8
Impacted Files Coverage Δ
pydantic/types.py 100% <100%> (ø) ⬆️
pydantic/schema.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7121de...612d3f8. Read the comment docs.

@samuelcolvin samuelcolvin merged commit f5cde39 into master Oct 21, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the conlist-fix-2 branch Oct 21, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant