Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow abstract sets in include and exclude arguments #921

merged 4 commits into from Oct 23, 2019


Copy link

samuelcolvin commented Oct 22, 2019

Change Summary

Ease the process of migrating to pydantic v1 by allowing abstracts sets (eg. dict keys) in the include and exclude arguments to dict().


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/ for details)
@samuelcolvin samuelcolvin force-pushed the abstract-sets branch from c3f1fb6 to 0d56cd0 Oct 22, 2019

This comment has been minimized.

Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #921 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #921   +/-   ##
  Coverage     100%   100%           
  Files          16     16           
  Lines        2799   2836   +37     
  Branches      543    556   +13     
+ Hits         2799   2836   +37
Impacted Files Coverage Δ
pydantic/ 100% <ø> (ø) ⬆️
pydantic/ 100% <100%> (ø) ⬆️
pydantic/ 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5adcc...7bbaff3. Read the comment docs.

@samuelcolvin samuelcolvin merged commit bab6970 into master Oct 23, 2019
11 checks passed
11 checks passed
Header rules No header rules processed
Pages changed 5 new files uploaded
Redirect rules No redirect rules processed
Mixed content No mixed content detected
codecov/project 100% (+0%) compared to 6b5adcc
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!
samuelcolvin.pydantic Build #20191023.13 succeeded
samuelcolvin.pydantic (Job Python36) Job Python36 succeeded
samuelcolvin.pydantic (Job Python37) Job Python37 succeeded
@samuelcolvin samuelcolvin deleted the abstract-sets branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.