Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upallow abstract sets in include and exclude arguments #921
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 22, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2799 2836 +37
Branches 543 556 +13
=====================================
+ Hits 2799 2836 +37
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
samuelcolvin commentedOct 22, 2019
•
edited
Change Summary
Ease the process of migrating to pydantic v1 by allowing abstracts sets (eg. dict keys) in the
include
andexclude
arguments todict()
.Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)