Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ValidationError.json() #922

merged 1 commit into from Oct 23, 2019

fix ValidationError.json() #922

merged 1 commit into from Oct 23, 2019


Copy link

@samuelcolvin samuelcolvin commented Oct 22, 2019

Change Summary

Fix JSON serialization errors on ValidationError.json() by using pydantic_encoder.


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/ for details)

Copy link

@codecov codecov bot commented Oct 22, 2019

Codecov Report

Merging #922 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #922   +/-   ##
  Coverage     100%   100%           
  Files          16     16           
  Lines        2799   2800    +1     
  Branches      543    543           
+ Hits         2799   2800    +1
Impacted Files Coverage Δ
pydantic/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cde39...9e91157. Read the comment docs.

@samuelcolvin samuelcolvin merged commit cb262da into master Oct 23, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the ValidationError.json branch Oct 23, 2019
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant