Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation and error message about keep_untouched #926

Merged
merged 5 commits into from Oct 23, 2019

Conversation

retnikt
Copy link
Contributor

@retnikt retnikt commented Oct 23, 2019

Resolves #924.

@dmontagu
Copy link
Collaborator

@dmontagu dmontagu commented Oct 23, 2019

I don’t think it’s strictly necessary, but I do think this could benefit from some practical examples of usage.

@codecov
Copy link

@codecov codecov bot commented Oct 23, 2019

Codecov Report

Merging #926 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #926   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2799   2800    +1     
  Branches      543    543           
=====================================
+ Hits         2799   2800    +1
Impacted Files Coverage Δ
pydantic/validators.py 100% <100%> (ø) ⬆️
pydantic/error_wrappers.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cde39...a12c91f. Read the comment docs.

@samuelcolvin samuelcolvin merged commit dccc401 into samuelcolvin:master Oct 23, 2019
10 checks passed
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
…olvin#926)

* Clarify keep_untouched documentation (samuelcolvin#924)

* Clarify error message for custom types (samuelcolvin#924)

* Fix tests for changed error message (samuelcolvin#924)

* fix formatting

* remove erroneous error message and add change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants