Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic typehint for pycharm #936

Merged
merged 2 commits into from Oct 29, 2019

Conversation

dmontagu
Copy link
Collaborator

@dmontagu dmontagu commented Oct 25, 2019

Change Summary

Modifies a type hint to prevent pycharm from raising warnings.

I believe this was caused by pycharm recently starting to incorporate the return type of __class_getitem__ into its type-checking logic.

Related issue number

tiangolo/fastapi#653

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

@codecov codecov bot commented Oct 25, 2019

Codecov Report

Merging #936 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #936   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines        2800   2800           
  Branches      543    543           
=====================================
  Hits         2800   2800

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f657f...8cd5b55. Read the comment docs.

@samuelcolvin samuelcolvin merged commit cb2a302 into samuelcolvin:master Oct 29, 2019
10 checks passed
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Oct 29, 2019

thanks.

andreshndz pushed a commit to cuenca-mx/pydantic that referenced this issue Jan 17, 2020
* Fix generic typehint for pycharm

* Add changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants