diff --git a/archetypal/template/building_template.py b/archetypal/template/building_template.py index b79dc1e5..ef78e234 100644 --- a/archetypal/template/building_template.py +++ b/archetypal/template/building_template.py @@ -31,6 +31,7 @@ class BuildingTemplate(UmiBase): .. image:: ../images/template/buildingtemplate.png """ + _CREATED_OBJECTS = [] __slots__ = ( @@ -543,6 +544,7 @@ def to_dict(self): data_dict["Perimeter"] = self.Perimeter.to_ref() data_dict["Structure"] = self.Structure.to_ref() data_dict["Windows"] = self.Windows.to_ref() + data_dict["DefaultWindowToWallRatio"] = self.DefaultWindowToWallRatio data_dict["Category"] = validators.string(self.Category, allow_empty=True) data_dict["Comments"] = validators.string(self.Comments, allow_empty=True) data_dict["DataSource"] = self.DataSource diff --git a/archetypal/umi_template.py b/archetypal/umi_template.py index 21af240a..c2d5c320 100644 --- a/archetypal/umi_template.py +++ b/archetypal/umi_template.py @@ -243,7 +243,7 @@ def from_idf_files( ) for filename, res in results.items(): if isinstance(res, EnergyPlusProcessError): - filename = (settings.logs_folder / "failed_reduce.txt").expand() + filename = settings.logs_folder / "failed_reduce.txt" with open(filename, "a") as file: file.writelines(res.write()) log( diff --git a/tests/input_data/umi_samples/BostonTemplateLibrary_nodup.json b/tests/input_data/umi_samples/BostonTemplateLibrary_nodup.json index 04d04365..f4a0f42f 100644 --- a/tests/input_data/umi_samples/BostonTemplateLibrary_nodup.json +++ b/tests/input_data/umi_samples/BostonTemplateLibrary_nodup.json @@ -4744,6 +4744,7 @@ "Windows": { "$ref": "179" }, + "DefaultWindowToWallRatio": 0.4, "Category": "Office Spaces", "Comments": "Base building definition for MIT 4433", "DataSource": "MIT_SDL", @@ -4779,6 +4780,7 @@ "Windows": { "$ref": "180" }, + "DefaultWindowToWallRatio": 0.4, "Category": "Retail", "Comments": "Base building definition for MIT 4433", "DataSource": "MIT_SDL", @@ -4814,6 +4816,7 @@ "Windows": { "$ref": "181" }, + "DefaultWindowToWallRatio": 0.4, "Category": "Residential and Lodging", "Comments": "Base building definition for MIT 4433", "DataSource": "MIT_SDL", @@ -4849,6 +4852,7 @@ "Windows": { "$ref": "181" }, + "DefaultWindowToWallRatio": 0.4, "Category": "Residential and Lodging", "Comments": "Base building definition for MIT 4433", "DataSource": "MIT_SDL",