Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node 16 #38

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Upgrade to node 16 #38

merged 2 commits into from
Nov 15, 2022

Conversation

sp1thas
Copy link
Contributor

@sp1thas sp1thas commented Nov 12, 2022

This PR fixes #37

yarn.lock has been updated too.

casperdcl
casperdcl reviewed Nov 12, 2022
View reviewed changes
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately some tests still failing

@sp1thas
Copy link
Contributor Author

sp1thas commented Nov 12, 2022 •
edited
Loading

unfortunately some tests still failing

Now is probably fixed, feel free to trigger the workflows

jodh-intel
jodh-intel reviewed Nov 14, 2022
View reviewed changes
Copy link

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sp1thas!

lgtm

@jodh-intel jodh-intel mentioned this pull request Nov 14, 2022
Closed
@casperdcl casperdcl merged commit 75db9a0 into samuelmeuli:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodh-intel jodh-intel jodh-intel left review comments

@casperdcl casperdcl casperdcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: Node.js 12 actions are deprecated.
3 participants
@sp1thas @casperdcl @jodh-intel