From 0fbed3b2c0fde262ccfa535b8ff26431c2b65e82 Mon Sep 17 00:00:00 2001 From: Joe Atzberger Date: Thu, 26 May 2016 17:25:46 -0700 Subject: [PATCH] Cleanup test secondary_terms test wasn't even testing secondary_terms. less derp, more good. --- spec/forms/sufia/batch_upload_form_spec.rb | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/spec/forms/sufia/batch_upload_form_spec.rb b/spec/forms/sufia/batch_upload_form_spec.rb index 3310a6559b..69e8781200 100644 --- a/spec/forms/sufia/batch_upload_form_spec.rb +++ b/spec/forms/sufia/batch_upload_form_spec.rb @@ -7,13 +7,12 @@ describe "#primary_terms" do subject { form.primary_terms } it { is_expected.to eq [:creator, :keyword, :rights] } + it { is_expected.not_to include(:title) } end describe "#secondary_terms" do - subject { form.primary_terms } - it "doesn't have title" do - expect(subject).not_to include(:title) - end + subject { form.secondary_terms } + it { is_expected.not_to include(:title) } # title is per file, not per form end describe ".model_name" do @@ -21,10 +20,7 @@ it "has a route_key" do expect(subject.route_key).to eq 'batch_uploads' end - it "has a param_key" do - derp = subject - derp.param_key expect(subject.param_key).to eq 'generic_work' end end