Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the FileSetController new and create methods #1703

Closed
jcoyne opened this issue Mar 30, 2016 · 3 comments
Closed

Remove the FileSetController new and create methods #1703

jcoyne opened this issue Mar 30, 2016 · 3 comments
Assignees
@jcoyne
Labels
technical debt
Milestone
7.0.0

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Mar 30, 2016

Descriptive summary

This is now handled by the new create workflow which is largely in WorkControllerBehavior
@jcoyne jcoyne added this to the 7.0.0 milestone Mar 30, 2016
@mjgiarlo
Copy link
Member

@jcoyne add to backlog if low priority?

@jcoyne
Copy link
Contributor Author

jcoyne commented Mar 30, 2016

I think that not removing this slows us down as we're maintaining a lot of useless code and tests. I'd like this to be done now.

@mjgiarlo
Copy link
Member

👌, I'm fine with that.

@mjgiarlo mjgiarlo added the ready label Mar 30, 2016
@hectorcorrea hectorcorrea self-assigned this Apr 5, 2016
@jcoyne jcoyne assigned jcoyne and unassigned hectorcorrea Apr 5, 2016
jcoyne added a commit that referenced this issue Apr 5, 2016
@jcoyne
Removed unused FileSetController and other methods
4ac88ed 
Fixes #1703
Fixes #1380
jcoyne added a commit that referenced this issue Apr 5, 2016
@jcoyne
Removed unused FileSetController and other methods
49bd77d 
Fixes #1703
Fixes #1380
@jcoyne jcoyne mentioned this issue Apr 5, 2016
Merged
@jcoyne jcoyne added in progress and removed ready labels Apr 5, 2016
jcoyne added a commit that referenced this issue Apr 5, 2016
@jcoyne
Removed unused FileSetController and other methods
52f94e0 
Fixes #1703
Fixes #1380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcoyne jcoyne

Labels
technical debt
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
3 participants
@jcoyne @mjgiarlo @hectorcorrea