Force redraw to destroy previous tiled image. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mathewjordan
force-pushed
the
203-update-active-canvas-bug
branch
from
4fe433a
to
442fd5a
Compare
adamjarling
approved these changes
May 1, 2024
| @@ -83,7 +83,7 @@ | |||
| "flexsearch": "^0.7.43", | |||
| "hls.js": "^1.5.3", | |||
| "node-webvtt": "^1.9.4", | |||
| "openseadragon": "^2.4.2", | |||
| "openseadragon": "^4.1.1", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #203 raised by @wykhuh. In some instances when navigating canvases of a manfiest, the expected IIIF tiled images is not drawn to the canvas and the previous item is retained. The actual occurance is a collision on the index of the canvas where the IIIF tiled image is strangely drawn under the previous tiled image that was somehow retained. In addition to the redraw, we now also update a timing issue where the
osdUriis not reset unless theopenSeadragoninstance exists.To resolve, we are now forcing a redraw prior to the drawing of the new image.
This also updates the
openseadragondependency as previous IIIF tile size issues have now been resolved in the recent release 4.1.1.