Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
more powerful ActiveFedora::FixityService #1239
The fedora fixity service also reports the expected message
Actually cache the http response. Comment erroneously implied
Cleaned up some erroneous comments.
This looks good, I just have a few questions regarding casting the responses.
Oh, forgot to mention I also replaced some of the mocked fedora responses in the test with actual responses from my fcrepo 4.7.0, which were quite different than what was mocked before (a different RDF serialization format?), but didn't break any of the existing tests, hooray.
If any new commits are made before I merge, Github makes me merge/rebase master into this branch again before I can click 'merge branch'. And then wait for travis to run again. and then hope nobody else has committed to master, or else I have to do the dance again.
Is this a problem for anyone else? If people are making frequent commits, it might become impossible to ever merge, as people make commits in the time it takes travis to run.
So tell me now @awead if you'd rather me hold off on this, otherwise I'm merging as soon as I notice travis being done again. :)