diff --git a/.travis.yml b/.travis.yml index 34f1a320..836cc74c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,16 +14,20 @@ before_install: - "if [ $(phantomjs --version) != '2.1.1' ]; then tar -xvf $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis_phantomjs; fi" - "phantomjs --version" rvm: - - 2.2 + - "2.2.2" +# rack 2 requires Ruby version >= 2.2.2 env: global: - NOKOGIRI_USE_SYSTEM_LIBRARIES=true matrix: - "RAILS_VERSION=4.1.10" - "RAILS_VERSION=4.2.1" + - "RAILS_VERSION=5.0.0.1" matrix: include: + - rvm: "2.3.0" + env: "RAILS_VERSION=5.0.0.1" - rvm: 2.1 env: "RAILS_VERSION=4.2.1" - rvm: 2.0 diff --git a/app/controllers/browse_everything_controller.rb b/app/controllers/browse_everything_controller.rb index c19b7abc..0b4d78a0 100644 --- a/app/controllers/browse_everything_controller.rb +++ b/app/controllers/browse_everything_controller.rb @@ -4,8 +4,8 @@ class BrowseEverythingController < ActionController::Base layout 'browse_everything' helper BrowseEverythingHelper - after_filter {session["#{provider_name}_token"] = provider.token unless provider.nil? } - + after_filter { session["#{provider_name}_token"] = provider.token unless provider.nil? } + def index render :layout => !request.xhr? end @@ -13,22 +13,21 @@ def index def show render :layout => !request.xhr? end - + def auth - code = params[:code] - session["#{provider_name}_token"] = provider.connect(params,session["#{provider_name}_data"]) + session["#{provider_name}_token"] = provider.connect(params, session["#{provider_name}_data"]) end def resolve selected_files = params[:selected_files] || [] - @links = selected_files.collect { |file| - p,f = file.split(/:/) + @links = selected_files.collect { |file| + p,f = file.split(/:/) (url,extra) = browser.providers[p].link_for(f) result = { url: url } result.merge!(extra) unless extra.nil? result } - respond_to do |format| + respond_to do |format| format.html { render :layout => false } format.json { render :json => @links } end @@ -40,7 +39,7 @@ def auth_link @auth_link ||= if provider.present? link, data = provider.auth_link session["#{provider_name}_data"] = data - link = "#{link}&state=#{provider.key}" unless link.include?("state") + link = "#{link}&state=#{provider.key}" unless link.to_s.include?('state') link else nil diff --git a/app/helpers/browse_everything_helper.rb b/app/helpers/browse_everything_helper.rb index ba6467a8..44fd0cb6 100644 --- a/app/helpers/browse_everything_helper.rb +++ b/app/helpers/browse_everything_helper.rb @@ -1,36 +1,25 @@ module BrowseEverythingHelper - - def array_to_hidden_fields(array,key) + def array_to_hidden_fields(array, key) fields = array.to_query(key).split(Rack::Utils::DEFAULT_SEP).collect do |pair| - key,value=pair.split('=', 2).map { |str| Rack::Utils.unescape(str) } - hidden_field_tag(key,value) + key, value = pair.split('=', 2).map { |str| Rack::Utils.unescape(str) } + hidden_field_tag(key, value) end fields.join("\n").html_safe end - # Extracted from Rack::Mime 1.5.2 for use with earlier versions - # of Rack/Rails + # Extracted from Rack::Mime 1.5.2 for use with earlier versions of Rack/Rails + # @param [String] value + # @param [String] matcher + # @return [TrueClass,FalseClass] def mime_match?(value, matcher) v1, v2 = value.split('/', 2) m1, m2 = matcher.split('/', 2) - - if m1 == '*' - if m2.nil? || m2 == '*' - return true - elsif m2 == v2 - return true - else - return false - end - end - - return false if v1 != m1 - - return true if m2.nil? || m2 == '*' - - m2 == v2 + return false if m1 != '*' && v1 != m1 + m2.nil? || m2 == '*' || m2 == v2 end + # @param [BrowseEverything::FileEntry] file + # @return [TrueClass,FalseClass] def is_acceptable?(file) acceptable = params[:accept] || '*/*' acceptable_types = acceptable.split(/,\s*/) diff --git a/app/views/browse_everything/_file.html.erb b/app/views/browse_everything/_file.html.erb index 9620e486..8bea9020 100644 --- a/app/views/browse_everything/_file.html.erb +++ b/app/views/browse_everything/_file.html.erb @@ -1,13 +1,10 @@ -<% unless file.relative_parent_path? %> - - <% if file.container? || provider.config[:max_upload_file_size].blank? #never disable a folder or if no maximum is set - disabled = false - else - max_size = provider.config[:max_upload_file_size].to_i - disabled = file.size > max_size - end - %> - +<% if file.container? || provider.config[:max_upload_file_size].blank? # never disable a folder or if no maximum is set + disabled = false + else + max_size = provider.config[:max_upload_file_size].to_i + disabled = file.size > max_size + end +%>