New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On master, a `..` entry shows up, and causes problems for (at least) S3 #215

Closed
jrochkind opened this Issue May 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@jrochkind
Contributor

jrochkind commented May 17, 2018

On browse-everything master, using the S3 driver, I get .. entries in my listings:

screen shot 2018-05-17 at 3 23 51 pm

That .. entry does not show up for me when using b-e 0.15.1.

So the first question is why the .. entry shows up at all. I can't think of any reason it would be useful to show here -- is it supposed to just open up the parent directory again, the one that's already on the screen in a different place in the hierarchy anyway? I can't figure out why this would be desirable UX.

I also have not yet figured out why it does not show up in 0.15.1, but does in master, what changes led to this I have not tracked down. I don't think it is any changes to the S3 driver itself, but changes elsewhere?

Secondly, if you decide to click on that .. entry, it results in a browser crash:

screen shot 2018-05-17 at 3 28 09 pm

I'm not sure why that is happening either -- my first guess was it might be an infinite loop of AJAX queries, but the Chrome dev console does not reveal that, or anything else of note to me. There is no server-side error in the logs that I can see.

So if you do show a .. entry, it ought not to cause a browser crash when you click on it. But really I'd rather it wasn't there at all, I don't understand what it's doing there.

ref #204
tag @mbklein

@jrochkind jrochkind changed the title from On master, a `..` entry shows up, and causes problems for S3 to On master, a `..` entry shows up, and causes problems for (at least) S3 May 17, 2018

@jrgriffiniii jrgriffiniii added this to the 1.0.0 milestone May 18, 2018

@jrochkind

This comment has been minimized.

Contributor

jrochkind commented Jun 13, 2018

I would love to be using master -- ideally in a release, not from github -- to get a variety of bugfixes in there (some months old) that are not in a release.

But I can not do so if it contains above, which from my perspective is a regression. From my perspecitve it's a regression that .. shows up in the listing at all, when it did not before for me, and I don't understand what values it has for anyone.

Can anyone say if there's any reason to want .. to show up in the listing, for any provider?

Seems to me, the first step would be a decision/agreement (by whom? product owner @mbklein ?) that .. should not show up in listings at all, there should be a patch so it does not. (For S3 driver, i was unable to find the code that put it there in the first place -- it seems like maybe it was an intentional code change to put it there, but I can't find it, and don't know why it would be).

The second (harder? hard to say :) ) step is then making it so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment