Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable server-side file upload limits #119

Open
mjgiarlo opened this issue Dec 21, 2016 · 0 comments
Open

Allow configurable server-side file upload limits #119

mjgiarlo opened this issue Dec 21, 2016 · 0 comments
Milestone

Comments

@mjgiarlo
Copy link
Member

@mjgiarlo mjgiarlo commented Dec 21, 2016

Issue by mjgiarlo
Tuesday Apr 12, 2016 at 17:47 GMT
Originally opened as samvera-deprecated/sufia#1827


Descriptive summary

We currently -- since #1821 was merged -- have the ability to define the following limits for the file upload widget:

  • Max size of individual file
  • Max size of group of files
  • Max number of files

This brings Sufia master to parity with Sufia 6.x, with limits defined in JavaScript and enforced by the client. Quoting @atz:

For robust file handling and avoidance of OOM/resource depletion, we need:

  • server side limits and proper handling there, e.g. in CarrierWave
  • should be configurable
  • client limits should take their values from (or be derived from) the server-side ones.

Alternatively, we can just be open to anybody crashing our processes with multi-TB web uploads and delete the js declarations.

(No, let's not be open to that.)

Pertains to Sufia master.

Related work

Decomposed from #1814
Follows #1821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant