Fix bug in date validation in admin_set form #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dananji is this a draft PR, or ready to go? |
|
@no-reply Yes this is ready. Sorry I forgot to mark it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4144
When creating a new work, the work form fails to load because a date validation check in admin_set edit forms introduced in #4067 leaked into the work form. This produces a JavaScript error causing failure in loading the work form.
Changes proposed in this pull request:
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Workspage inDashboardAdd new workCreate workin the modal@samvera/hyrax-code-reviewers