Allow configurable server-side file upload limits #1827

Closed
mjgiarlo opened this Issue Apr 12, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@mjgiarlo
Member

mjgiarlo commented Apr 12, 2016

Descriptive summary

We currently -- since #1821 was merged -- have the ability to define the following limits for the file upload widget:

  • Max size of individual file
  • Max size of group of files
  • Max number of files

This brings Sufia master to parity with Sufia 6.x, with limits defined in JavaScript and enforced by the client. Quoting @atz:

For robust file handling and avoidance of OOM/resource depletion, we need:

  • server side limits and proper handling there, e.g. in CarrierWave
  • should be configurable
  • client limits should take their values from (or be derived from) the server-side ones.

Alternatively, we can just be open to anybody crashing our processes with multi-TB web uploads and delete the js declarations.

(No, let's not be open to that.)

Pertains to Sufia master.

Related work

Decomposed from #1814
Follows #1821

@mjgiarlo mjgiarlo added this to the 7.1.0 milestone Apr 12, 2016

@mjgiarlo mjgiarlo modified the milestones: 7.1.0, 7.2.0 Aug 10, 2016

@younga3 younga3 referenced this issue in samvera-labs/sufia.io Aug 11, 2016

Closed

New question about filesize and # of files limits #3

@jcoyne jcoyne modified the milestones: 7.2.0, 7.3.0 Sep 8, 2016

@mjgiarlo mjgiarlo modified the milestones: Backlog, 7.3.0 Dec 20, 2016

@mjgiarlo mjgiarlo closed this Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment